[cp-patches] RFC: Path canonicalizer

Gary Benson gbenson at redhat.com
Thu Apr 6 10:34:39 UTC 2006


Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <mark at klomp.org> writes:
> 
> Mark> It does look good to me. But in theory the usage of PATH_MAX
> Mark> PATH_MAX might be a problem.
> 
> Yeah, this famously is not defined in Hurd.
> 
> Do we really need a limit here?  Can't we just resize the buffer
> dynamically as needed?

It's possible, I suppose, but it seems over-complex when libgcj
manages to sidestep the PATH_MAX thing just fine with:

  #ifndef MAXPATHLEN
   #define MAXPATHLEN 4096
  #endif

Also, aren't malloc/realloc and friends slow calls?

Cheers,
Gary



More information about the Classpath-patches mailing list