[cp-patches] Cleanup new compiler warnings

Andreas Tobler toa at pop.agri.ch
Thu Jun 1 19:49:50 UTC 2006


Hi Mark,

Mark Wielaard wrote:
> Hi Andreas,
> 
> On Thu, 2006-06-01 at 21:16 +0200, Andreas Tobler wrote:
>> Mark Wielaard wrote:
>>
>>>     * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkTextLayout.c
>>>     (Java_gnu_java_awt_peer_gtk_GdkTextLayout_cairoDrawGdkTextLayout):
>>>     Remove unused cairographics2d struct.
>>>     (_moveTo, _lineTo, _quadTo, _curveTo): Mark arguments const.
>> This part results in new warnings on my side.
>>
>> What is your freetype2 version? Do we need a special version?
>>
>> The one I have on linux-ppc (FC4) and darwin-ppc has no const qualifiers 
>> in the freetype2/freetype/ftimage.h for these functions.
>> Yours seem to have. I saw in the cvs of freetype2 that there are now.
>>
>> Any thoughts on this?
> 
> Darn, I had hoped adding the consts as they are in current freetype2
> headers (I have 2.2.1 installed) would also work with the older
> versions. We don't necessarily need this latest version except for
> getting clean warning free compile. Maybe we can come up with a
> configure check to see whether we need const arguments or not?

Well, I agree, not necessarily needed, but would be nice to be clean.
The config check will be probably the only way I see. Means freetype2 
version < 2.2.0 _no_ const qualifiers, freetype2 version >= 2.2.0 use const.

But, my freetype2 version shows 9.7.3 :( from X.org......

Have to think about it then.

Thanks,
Andreas



More information about the Classpath-patches mailing list