[cp-patches] FYI: fix for ConfigFileParser

Tom Tromey tromey at redhat.com
Sun Jun 11 17:17:08 UTC 2006


>>>>> "Raif" == Raif S Naffah <raif at swiftdsl.com.au> writes:

Raif>          String t = tokens[i];
Raif> -        if (Character.isJavaIdentifierStart(cn.toCharArray()[0]))
Raif> -          abort("");
Raif> +        if (! Character.isJavaIdentifierStart(t.toCharArray()[0]))
Raif> +          abort("Class name [" + cn
Raif> +                + "] contains an invalid sub-package identifier: " + t);
This code looks pretty weird.
I think Character.isJavaIdentifierStart(t.charAt(0)) would be much
more efficient.

Tom



More information about the Classpath-patches mailing list