[cp-patches] Re: fix for ConfigFileParser

Raif S. Naffah raif at swiftdsl.com.au
Mon Jun 12 04:01:27 UTC 2006


hello Tom,

On Monday 12 June 2006 03:17, Tom Tromey wrote:
> >>>>> "Raif" == Raif S Naffah <raif at swiftdsl.com.au> writes:
>
> Raif>          String t = tokens[i];
> Raif> -        if
> (Character.isJavaIdentifierStart(cn.toCharArray()[0])) Raif> -       
>   abort("");
> Raif> +        if (!
> Character.isJavaIdentifierStart(t.toCharArray()[0])) Raif> +         
> abort("Class name [" + cn
> Raif> +                + "] contains an invalid sub-package
> identifier: " + t); This code looks pretty weird.
> I think Character.isJavaIdentifierStart(t.charAt(0)) would be much
> more efficient.

indeed.  the attached patch does that.


cheers;
rsn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: classpath-20060612a.patch
Type: text/x-diff
Size: 707 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060612/4c403e54/classpath-20060612a.bin


More information about the Classpath-patches mailing list