[cp-patches] RFC: AbstractButton

Thomas Fitzsimmons fitzsim at redhat.com
Tue Jun 13 16:09:05 UTC 2006


Tania Bento wrote:
> Hey,
> 
> In the constructor, focusable should be set to false and not true.
> Could someone please approve and commit this for me.  Thanks a bunch.
> 
> 2006-06-13  Tania Bento  <tbento at redhat.com>
> 
>         * javax/swing/AbstractButton.java
>         (AbstractButton): Set focusable to false, not true.

Looks good, thanks.  Mark, can we set Tania up with commit access?

Tom

> 
> Cheers,
> Tania
> 
> 
> ------------------------------------------------------------------------
> 
> Index: AbstractButton.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/javax/swing/AbstractButton.java,v
> retrieving revision 1.58
> diff -u -r1.58 AbstractButton.java
> --- AbstractButton.java	8 May 2006 08:57:57 -0000	1.58
> +++ AbstractButton.java	13 Jun 2006 15:55:54 -0000
> @@ -866,7 +866,7 @@
>      borderPainted = true;
>      contentAreaFilled = true;
>      focusPainted = true;
> -    setFocusable(true);
> +    setFocusable(false);
>      setAlignmentX(CENTER_ALIGNMENT);
>      setAlignmentY(CENTER_ALIGNMENT);
>      setDisplayedMnemonicIndex(-1);




More information about the Classpath-patches mailing list