[cp-patches] Re: RFA JDWP ExceptionOnlyFilter

Kyle Galloway kgallowa at redhat.com
Tue Jun 13 16:17:15 UTC 2006


Yeah, sorry, should have seen that before, I think when I changed the 
logic to compress it I may have destroyed that functionality.  Anyways 
fixed now.

2006-06-13  Kyle Galloway <kgallowa at redhat.com>

    * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java: Allow
    null refId.
    (matches): Filter on all exceptions.

Keith Seitz wrote:
> Kyle Galloway wrote:
>> 2006-06-13  Kyle Galloway <kgallowa at redhat.com>
>>
>>     * gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java: Allow
>>    null refId.
>
> Grr. I really hate to do this, but I just noticed... 
> ExceptionOnlyFilter.matches doesn't handle the case where _refId is null.
>
> Since you're updating ExceptionOnlyFilter to properly handle the "all 
> exceptions" case, could you also update the matches method?
>
> My bad,
> Keith

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 2306 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060613/deacc17e/patch-0001.bin


More information about the Classpath-patches mailing list