[cp-patches] Patch: PixelGrabber fix

Tom Tromey tromey at redhat.com
Tue Jun 13 18:16:16 UTC 2006


>>>>> "Lillian" == Lillian Angel <langel at redhat.com> writes:

Lillian> The JDK doesnt care if the ImageProducer is null when passed to the
Lillian> constructor.

Lillian> -    if (ip == null)
Lillian> -      throw new NullPointerException("The ImageProducer must not be null.");

In cases like this it is nice to have a comment, either in the
javadoc or in the code, explaining what happens when ip==null.
That way nobody will be tempted to add the check back in later.

Tom



More information about the Classpath-patches mailing list