[cp-patches] Patch: PixelGrabber fix

Lillian Angel langel at redhat.com
Tue Jun 13 19:01:02 UTC 2006


On Tue, 2006-06-13 at 12:16 -0600, Tom Tromey wrote:
> >>>>> "Lillian" == Lillian Angel <langel at redhat.com> writes:
> 
> Lillian> The JDK doesnt care if the ImageProducer is null when passed to the
> Lillian> constructor.
> 
> Lillian> -    if (ip == null)
> Lillian> -      throw new NullPointerException("The ImageProducer must not be null.");
> 
> In cases like this it is nice to have a comment, either in the
> javadoc or in the code, explaining what happens when ip==null.
> That way nobody will be tempted to add the check back in later.
> 

Good idea.

2006-06-13  Lillian Angel  <langel at redhat.com>

        * java/awt/image/PixelGrabber.java
        (PixelGrabber): Added to API documentation.




> Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: app.diff
Type: text/x-patch
Size: 888 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060613/9f4b082e/app-0001.bin


More information about the Classpath-patches mailing list