[cp-patches] FYI: PixelGrabber fix

Lillian Angel langel at redhat.com
Tue Jun 13 19:06:39 UTC 2006




On Tue, 2006-06-13 at 15:01 -0400, Lillian Angel wrote:
> On Tue, 2006-06-13 at 12:16 -0600, Tom Tromey wrote:
> > >>>>> "Lillian" == Lillian Angel <langel at redhat.com> writes:
> > 
> > Lillian> The JDK doesnt care if the ImageProducer is null when passed to the
> > Lillian> constructor.
> > 
> > Lillian> -    if (ip == null)
> > Lillian> -      throw new NullPointerException("The ImageProducer must not be null.");
> > 
> > In cases like this it is nice to have a comment, either in the
> > javadoc or in the code, explaining what happens when ip==null.
> > That way nobody will be tempted to add the check back in later.
> > 
> 
> Good idea.
Attached is the new patch.

> 
> 2006-06-13  Lillian Angel  <langel at redhat.com>
> 
>         * java/awt/image/PixelGrabber.java
>         (PixelGrabber): Added to API documentation.
> 
> 
> 
> 
> > Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 817 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060613/6fd2490e/patch.bin


More information about the Classpath-patches mailing list