[cp-patches] RFC: JDWP startup synchronization (revisited)

Keith Seitz keiths at redhat.com
Fri Jun 16 18:47:39 UTC 2006


Tom Tromey wrote:

> I'm probably missing something, since it looks like your patch does
> use wait/notify.

Oh, sorry. I wasn't clear. I meant wait/notify from the VM into JDWP, 
not within JDWP itself. (Calling jdwpThread->wait() would crash gij.)

> I'm not overly concerned about the mechanics of how this works.  If
> it doesn't satisfy some VM we can always revisit it.

Ok.

> Keith> +	while (_initCount != 2)
> Keith> +	  {
> Keith> +	    synchronized (_initLock)
> Keith> +	      {
> Keith> +		_initLock.wait ();
> Keith> +	      }
> Keith> +	  }
> 
> Probably put the synchronized around the loop instead of inside it,
> so the _initCount check is synchronized.

Silly me. I've changed that and committed this patch.

Thank you for taking a moment to peek at this.

Keith



More information about the Classpath-patches mailing list