[cp-patches] [RFA] Fail configure if --enable-plugin and --disable-gtk-peer?

Tom Tromey tromey at redhat.com
Mon Jun 19 14:31:50 UTC 2006


>>>>> "Keith" == Keith Seitz <keiths at redhat.com> writes:

Keith> Ah, that looks like a better approach than what I did. I incorrectly
Keith> assumed gtk-peers was needed. Not peers, just gtk.

Keith> Can someone look at Paul's patch in 27923: It is really quite
Keith> small... Or suggest something better? This is a really big annoyance.

I took a quick look at the patch.  It seems to me that we could end
up checking for gtk+-2.0 in two different ways... that doesn't seem
too good.

I think a little refactoring would be better.  We could hoist the code
to check for gtk so that it is done when needed by either the peers or
appletviewer, and then use the result of that for the subsequent
checks.

Alternatively... I don't think your original patch was too bad, but
then, I don't think the situation where the user wants to build the
applet viewer but not the gtk peers is one that is really worth much
effort on our part.

Tom



More information about the Classpath-patches mailing list