[cp-patches] RFA: JMenu Constructor Regressions

Tania Bento tbento at redhat.com
Tue Jun 20 20:53:14 UTC 2006


Sorry, forgot to mention that these specific changes are due to the
getPopUpMenu.java mauve test I just committed.

Tania

On Tue, 2006-06-20 at 16:52 -0400, Tania Bento wrote:
> Hey,
> 
> I have written a test for all of JMenu's constructors and found many
> constructor regressions.  This patches fixes all of them.  Could someone
> please approve this patch so that I may commit it.  Thanks.
> 
> Here's the Changelog entry:
> 
> 2006-06-20  Tania Bento  <tbento at redhat.com>
> 
>         * javax/swing/JMenu.java
>         Changed instantiation of popupMenu to null.
>         (JMenu): Instantiated popupMenu to new JPopupMenu.
>         (JMenu): Instantiated popupMenu to new JPopupMenu.
>         (add): Changed popupMenu to getPopupMenu().
>         (add): Changed popupMenu to getPopupMenu().
>         (add): Changed popupMenu to getPopupMenu().
>         (add): Changed popupMenu to getPopupMenu().
>         (remove): Changed popupMenu to getPopupMenu().
>         (remove): Changed popupMenu to getPopupMenu().
>         (insert): Changed popupMenu to getPopupMenu().
>         (setSelectedHelper): Changed popupMenu to getPopupMenu().
>         (isPopupMenuVisible): Changed popupMenu to getPopupMenu().
>         (setPopupMenuVisible): Changed popupMenu to getPopupMenu().
>         (getMenuComponentCount): Changed popupMenu to getPopupMenu().
>         (getMenuComponents): Changed popupMenu to getPopupMenu().
>         (getPopupMenu): Check first if popupMenu is null and if so,
>         instantiate it to a new JPopupMenu and set the invoker.
> 




More information about the Classpath-patches mailing list