[cp-patches] RFA: Window.java

Roman Kennke roman at kennke.org
Thu Jun 22 21:15:49 UTC 2006


Hi Tania,

> The invalidate() method should be called within the hid() method of
> Window.java.  This now causes Harmony's
> testDispse(test.java.awt.WindowRTest) to pass on Classpath.

Some quick testing shows that invalidate() isn't called from hide() in
the RI, at least not directly from the hide() method. ATM we do call
invalidate() on the parent of a component in Component.hide() and iirc
this is correct. You can test this by subclassing Window and overriding
hide() and invalidate() to print the stacktrace, to find out that hide()
doesn't call invalidate() directly.

I am nitpicking here, because I have seen very strange bugs and/or
performance issues popping up by messing around with invalidate() at the
wrong places, sorry.


/Roman

-- 
“Improvement makes straight roads, but the crooked roads, without
Improvement, are roads of Genius.” - William Blake
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060622/5554cadf/attachment-0001.pgp


More information about the Classpath-patches mailing list