[cp-patches] RFC: GConf updates

Mario Torre neugens at limasoftware.net
Thu Jun 22 22:20:02 UTC 2006


Hi!

I've checked this twice, but given the kind of update I suggest to give
another look at it, so this is also a RFA.

This release contains a couple of fixes, most important it adds explicit
tests in the GConf native layer so that an invalid key does not results
in a crash.
I have added also some new javadoc comments and fixed some old ones.
I have also updated the default path for user nodes from /apps/java
to /apps/classpath.

If you think this is fine, please commit for me, as I don't have write
access to the CVS.

Thanks,
Mario


2006-06-22  neugens  <neugens at limasoftware.net>
    * native/jni/gconf-peer/GConfNativePeer.c:
    Fixed indentation to be more compliant to the GNU coding guidelines.

Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1unset):
    Added explicit test for errors in the GConf backend.

(Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1get_1string):
    Added explicit test for errors in the GConf backend. Fixed
Segmentation
    Fault when non valid key names are given as input.

(Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1set_1string):
    likewise.

(Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1dir_1exists):
    Added explicit test for errors in the GConf backend.
    * gnu/java/util/prefs/gconf/GConfNativePeer.java:
    Added javadoc comments for all native methods.
    (nodeExist): removed test to check for valid absolute path name for
nodes.
    (startWatchingNode): likewise.
    (stopWatchingNode): likewise.
    (setString): likewise, plus fixed javadoc comments.
    (unset): likekwise.
    (getKey): likewise.
    (getKeys): likewise, also fixed javadoc comments.
    (getChildrenNodes): likewise.
    * gnu/java/util/prefs/GConfBasedPreferences.java:
    changed DEFAULT_USER_ROOT to /apps/classpath.
    (constructor): Test to check for a valid absolute path for nodes is
now
    in the contructor for that node, instead of being on each method of
the
    backend.
    (getGConfKey): removed empty new line.



-- 
Lima Software, SO.PR.IND. s.r.l.
http://www.limasoftware.net/
pgp key: http://subkeys.pgp.net/

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gconf_preference.patch.tar.gz
Type: application/x-compressed-tar
Size: 5362 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060623/70c43d9c/gconf_preference.patch.tar.bin


More information about the Classpath-patches mailing list