[cp-patches] RFC: javax.swing.text.DefaultCaret

Mark Wielaard mark at klomp.org
Sun Jun 25 19:48:02 UTC 2006


Hi Carsten,

On Wed, 2006-06-21 at 19:58 +0200, Carsten Neumann wrote:
> Mark Wielaard wrote:
> >> Mark Wielaard wrote:
> > I see this was never applied, sorry about that.
> > Could you take a look at DefaultCaret and see if it is still the correct
> > way to implement this? Since you submitted the patch Robert added some
> > new logic and an active field to that class.
> 
> In answer to your question, I do believe the patch implements what the
> API doc of the RI specifies, but I'm not sure if that's also what the RI
> does ;)

It looks fine to me. And I see the active flag that Robert added
indicates whether the text component of the caret is editable and
enabled which is not exactly what isActive() is about, so I think your
implementation is fine.

> Anyway, I updated the patch, so it is now against current cvs.

Thanks, I'll apply it as follows:

2006-06-25  Carsten Neumann  <cn-develop at gmx.net>

        * javax/swing/text/DefaultCaret.java (isActive): New method.

Cheers,

Mark




More information about the Classpath-patches mailing list