[cp-patches] FYI: JComponent fixes

Mark Wielaard mark at klomp.org
Tue Jun 27 08:54:59 UTC 2006


On Mon, 2006-06-26 at 11:42 +0200, Roman Kennke wrote:
> Hiyo,
> 
> > Roman> 1. All PropertyChangeEvent methods have been removed.
> > 
> > According to JAPI, two of the firePropertyChange methods were public
> > in this class, but are protected in the superclass.  So, this part of
> > the change should be reverted.
> > 
> > Roman>         (firePropertyChange(String,boolean,boolean)): Likewise.
> > Roman>         (firePropertyChange(String,int,int)): Likewise.
> > 
> > These are the ones...
> 
> Indeed. Stupid API ;-) Fixed by the attached patch.

And unfortunately we need one other one pointed out by the autobuilder
since gcj 4.1 gets terribly confused by not having this one public in
JComponent itself:

2006-06-27  Mark Wielaard  <mark at klomp.org>

        * javax/swing/JComponent.java
        (firePropertyChange(String,char,char)): New override method.

Committed,

Mark

diff -u -r1.131 JComponent.java
--- javax/swing/JComponent.java 26 Jun 2006 09:41:33 -0000      1.131
+++ javax/swing/JComponent.java 27 Jun 2006 08:53:29 -0000
@@ -1020,6 +1020,21 @@
   }

   /**
+   * Fires a property change for a primitive character property.
+   *
+   * @param property the name of the property
+   * @param oldValue the old value of the property
+   * @param newValue the new value of the property
+   */
+  public void firePropertyChange(String property, char oldValue,
+                                 char newValue)
+  {
+    //  FIXME - This method is already public in awt Component, but
+    //  is included here to work around a compilation bug in gcj 4.1.
+    super.firePropertyChange(property, oldValue, newValue);
+  }
+
+  /**
    * Get the value of the accessibleContext property for this component.
    *
    * @return the current value of the property





More information about the Classpath-patches mailing list