[cp-patches] RFC: Crypto PBEKeySpec password references

Casey Marshall csm at gnu.org
Thu Jun 29 22:36:48 UTC 2006


On Jun 29, 2006, at 3:24 PM, Matthew Wringe wrote:

> Hi,
>
> I have attached a very small patch that fixes PR28204 : PBEKeySpec
> incorrectly deletes the originally passed password array
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28204)
>
> Instead of taking a reference to the passed password, it now creates a
> copy of it.
>

This looks fine, except for this space here at the end:

> +    System.arraycopy(password, 0, this.password, 0,  
> password.length );

And you can accomplish the same thing with `clone()'.

The JavaDoc should also be updated to explain that a copy of the  
argument is made (the JDK documentation says this, and it is an  
important API detail).

I'll be out of town for the next few days, so if someone else can  
commit this, I'd appreciate it.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 478 bytes
Desc: This is a digitally signed message part
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060629/c5993187/PGP-0001.pgp


More information about the Classpath-patches mailing list