[cp-patches] FYI:javax/swing/ViewportLayout.java (layoutContainer) rewrite

Audrius Meskauskas audriusa at bluewin.ch
Sun Mar 19 21:57:29 UTC 2006


Roman Kennke wrote:

>Hi Audrius,
>
>Am Sonntag, den 19.03.2006, 11:45 +0100 schrieb Audrius Meskauskas:
>  
>
>>The current ViewportLayout.java.layoutContainer method seems behaving 
>>differently from Sun's implementation in the following ways:
>>1. If the view is smaller than the port where it should be displayed, 
>>the view is bottom aligned. For instance, if the table is displayed in 
>>the frame that is larger than the table size, the table body is bottom 
>>aligned (large whitespace between table header and table body). This is 
>>not correct, in Sun's implementation the table is always top aligned is 
>>such case.
>>2. If the view width is exactly the same as the view port width, it 
>>should be set as such and the view offset must be set to zero, instead 
>>of performing unnecessary calculations.  Somehow the view offset is 
>>calculated different from zero, this results the unexpected whitespace 
>>at the left border of the tables and text areas in the Swing demo.
>>
>>The patch seems bringing no regressions, as far as I was able to test.
>>    
>>
>
>Thanks for fixing this. Do you think you could write a testcase for the
>problem you originally had?
>
>/Roman
>
>  
>
I only used visual tests at the moment. However the table was really 
bottom aligned,
and the empty area before the first table column was also discussed in 
FOSDEM.

Audrius.





More information about the Classpath-patches mailing list