[cp-patches] RFC: java.awt.Window fixlet

Wolfgang Baer WBaer at gmx.de
Thu Mar 23 21:56:42 UTC 2006


Hi,

reverse japi points out that some methods must be overriden and
made final in Window. A mauve test for this is committed
(gnu/testlet/java/awt/Window/focusCycleRootTest.java).

The API docs describe that these methods always return the same or
do nothing at all for Window. I needed to adjust one method
in Container to prevent a NPE. You can observe this NPE in the Swing
Demo if you use the ThemeEditor (try with and without the Container
NPE fixlet).

Playing around with the Swing/Awt demos showed no further problems.

2006-03-23  Wolfgang Baer  <WBaer at gmx.de>

	* java/awt/Window.java: 	
	(setFocusCycleRoot): New overriden method.
	(isFocusCycleRoot): Likewise.
	(getFocusCycleRootAncestor): Likewise.
	* java/awt/Container.java:
	(getFocusTraversalPolicy): Check also for anchestor == null.

OK to commit, comments ?

Wolfgang


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Window.patch
Type: text/x-patch
Size: 2031 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060323/b6bf3c23/Window.bin


More information about the Classpath-patches mailing list