[cp-patches] FYI: GapContentPosition fix

Robert Schuster theBohemian at gmx.net
Thu May 18 11:24:19 UTC 2006


Hi.

Cool that this is now fixed.

> However, there is one (minor IMO) problem left. As it is now, the
> positionMarks array is never cleaned up, that means that marks are kept
> there, even if their corresponding GapContentPosition is GC'ed. This
> might get slightly inefficient in large documents with lots of edits.
> However, the fact that marks and GapContentPositions are reused when
> possible alleviates for that inefficiency a little. So the array can
> never grow larger than the maximum document length. We might want to
> consider to either track GapContentPositions beeing GC'ed (using a
> ReferenceQueue) or perform some manual cleanup regularily. I added a
> FIXME for that.
Could you open a PR for that. FIXMEs tend to be forgotten ...

cya
Robert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20060518/57ccb1ae/signature.pgp


More information about the Classpath-patches mailing list