[cp-patches] FYI: Make VMChannel.open thread-safe

Mark Wielaard mark at klomp.org
Thu Mar 29 13:51:57 UTC 2007


On Wed, 2007-03-28 at 21:57 +0200, Christian Thalinger wrote:
> On Wed, 2007-03-28 at 11:48 +0200, Mark Wielaard wrote:
> > Andrew and Christian pointed out that the way we fiddle with umask is 1)
> > not-thread-safe and 2) unnecessary. So this patch fixes that up. It also
> > removes the linking against libclasspathnative for the nio library since
> > it doesn't actually uses that (it uses javanio.h).
> 
> At least one function is used:
> 
> cacao: symbol lookup error: /home/twisti/tmp/classpath/lib/classpath/libjavanio.so: undefined symbol: cpio_closeOnExec

Blush
Although tom is probably right I have reinstated it:

2007-03-28  Mark Wielaard  <mark at klomp.org>

    * native/jni/java-nio/Makefile.am (LIBADD): Add libclasspathnative.

The regression builder was also unhappy about this changed.

Sorry,

Mark

diff -u -r1.29 Makefile.am
--- native/jni/java-nio/Makefile.am     28 Mar 2007 09:48:06 -0000      1.29
+++ native/jni/java-nio/Makefile.am     29 Mar 2007 13:51:13 -0000
@@ -12,6 +12,7 @@
                        javanio.h
 
 libjavanio_la_LIBADD = $(top_builddir)/native/jni/classpath/jcl.lo \
+                      $(top_builddir)/native/jni/native-lib/libclasspathnative.la \
                       $(LTLIBICONV) 
 
 # Directly included through javanio.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20070329/2bbd730d/attachment.pgp


More information about the Classpath-patches mailing list