[cp-patches] RFC: iconv -Werror compilation fix

Tom Tromey tromey at redhat.com
Thu Mar 29 22:35:38 UTC 2007


>>>>> "Twisti" == Christian Thalinger <twisti at complang.tuwien.ac.at> writes:

Twisti> This patch fixes -Werror compilation with !HAVE_ICONV.  Daney
Twisti> pointed me to the (void)-solution.  I'm not sure if that is
Twisti> the best solution, but it works.

Twisti> Comments?

We discussed on irc but I thought the answer should be in the list
archives too.

Annotation the argument with UNUSED.  This is defined in config.h.
We already use this all over; gcc's "__attribute__ ((unused))" really
means "might or might not be used".

Tom



More information about the Classpath-patches mailing list