[cp-patches] FYI: more CopyOnWriteArrayList fixlets

Mario Torre neugens at limasoftware.net
Sat Nov 24 22:25:05 UTC 2007


I'm committing this one, that fixes a couple of "woops!" I did in the
last patch, as well as some other methods that were already broken
(read: not my fault :)

Now it should pass all the public domain tck166 tests, except for
subList.

Thanks,
Mario

2007-11-24  Mario Torre  <neugens at limasoftware.net>

	* java/util/concurrent/CopyOnWriteArrayList.java: 
	(addAll): fix implementation, now add elements in the correct position.
	(addAllAbsent): fixed typos (woops!).
	(remove(int)): fixed range in arraycopy that was causing for incorrect
	values to be inserted in the list. Refactored to give variables better
	names.
	(remove(Object)): refactored to give better names to variable.
	(listIterator): fix to set the starting index.
    (listIterator.previous): fix to decrement element position before
    returning the previous element in the iterator.  

-- 
Lima Software - http://www.limasoftware.net/
GNU Classpath Developer - http://www.classpath.org/
Fedora Ambassador - http://fedoraproject.org/wiki/MarioTorre
Jabber: neugens at jabber.org
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2007-11-24-copy-on-write-array-list.patch
Type: text/x-patch
Size: 4959 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20071124/88823964/2007-11-24-copy-on-write-array-list.bin


More information about the Classpath-patches mailing list