[cp-patches] [PATCH] Fix java.lang.Class field and method API for null names

Dr Andrew John Hughes ahughes at redhat.com
Mon Dec 13 12:53:16 UTC 2010


On 14:41 Mon 13 Dec     , Pekka Enberg wrote:
> On Mon, Dec 13, 2010 at 12:08 PM, Andrew Haley <aph at redhat.com> wrote:
> > On 12/12/2010 11:46 AM, Pekka Enberg wrote:
> >> This patch fixes Class getDeclaredField, getDeclaredMethod, getField, and
> >> getMethod API to throw NullPointerException if given name is "null".
> >
> > Thanks, but two things:
> >
> > a.  What happens with the current code base?
> 
> We throw NoSuchFieldException or NoSuchMethodException. I saw that
> because of a test case we had written in Malva which has very strict
> API checks.
> 
> > b.  We need a change log entry.
> 
> OK, I'm sorry I'm having some difficulties adjusting to GNU style of
> working. I'll update the patch and resend.
> 

Please just post a ChangeLog in the mail.  Don't include it in the patch
as it makes it hard to apply.

Also, as stated before, we can't yet apply these until the copyright
assignment is sorted.

>                         Pekka
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the Classpath-patches mailing list