[cp-patches] [PATCH] Fix java.lang.Class field and method API for null names

Dr Andrew John Hughes ahughes at redhat.com
Fri Jan 21 13:04:09 UTC 2011


On 13:33 Fri 21 Jan     , Pekka Enberg wrote:
> On Mon, Dec 13, 2010 at 5:41 PM, Pekka Enberg <penberg at kernel.org> wrote:
> > On Mon, Dec 13, 2010 at 2:53 PM, Dr Andrew John Hughes
> > <ahughes at redhat.com> wrote:
> >>> OK, I'm sorry I'm having some difficulties adjusting to GNU style of
> >>> working. I'll update the patch and resend.
> >>
> >> Please just post a ChangeLog in the mail.  Don't include it in the patch
> >> as it makes it hard to apply.
> >
> > 2010-12-13  Pekka Enberg <penberg at kernel.org>
> >
> >        * java/lang/Class.java:
> >        (getDeclaredField): Throw NullPointerException instead of
> >        NoSuchFieldException if name is null.
> >        (getField): Likewise.
> >        (getDeclaredMethod): Throw NullPointerException instead of
> >        NoSuchMethodException if name is null.
> >        (getMethod): Likewise.
> >
> >> Also, as stated before, we can't yet apply these until the copyright
> >> assignment is sorted.
> >
> > I've signed the papers and sent them back to FSF so hopefully that'll
> > be cleared soon.
> 
> Ping? What do I need to do to get this patch merged? My paperwork has
> been approved now.

The patch looks ok to me.  You need to apply to join the Classpath group on
Savannah (https://savannah.gnu.org/projects/classpath) to get commit access.
Once approved, you can commit.

Alternatively, one of us can commit for you but it might be more
expedient to sort commit access out for yourself.  Please be aware
that non-trivial patches still need to be reviewed before commit.

Oh, and always make sure Classpath still builds before committing :-)
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the Classpath-patches mailing list