[cp-patches] [PATCH] Implement Pattern.quote() API method

Ivan Maidanski ivmai at mail.ru
Thu Jan 27 20:28:33 UTC 2011


Hi Pekka,

Thanks.

1. "private TestHarness harness;" is not needed.

2. I hope (when you were composing this test case) that you produced the result value for "abc\\E123\E" manually by reading the spec, not by executing quote() and copy-pasting its result to this test case code ;)

Regards.

Wed, 26 Jan 2011 23:26:03 +0200  Pekka Enberg <penberg at cs.helsinki.fi>:

> On Wed, 2011-01-26 at 23:33 +0300, Ivan Maidanski wrote:
> > Please add a test for a string containing \E, e.g, "abc\\E123\E"
> 
> Here's a new version of the test case.
> 
> Pekka
> 
> // Tags: JDK1.5
> 
> // Copyright (C) 2011 Pekka Enberg
> 
> // This file is part of Mauve.
> 
> // Mauve is free software; you can redistribute it and/or modify
> // it under the terms of the GNU General Public License as published by
> // the Free Software Foundation; either version 2, or (at your option)
> // any later version.
> 
> // Mauve is distributed in the hope that it will be useful,
> // but WITHOUT ANY WARRANTY; without even the implied warranty of
> // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> // GNU General Public License for more details.
> 
> // You should have received a copy of the GNU General Public License
> // along with Mauve; see the file COPYING.  If not, write to
> // the Free Software Foundation, 59 Temple Place - Suite 330,
> // Boston, MA 02111-1307, USA.
> 
> package gnu.testlet.java.util.regex.Pattern;
> 
> import gnu.testlet.*;
> import java.util.regex.*;
> 
> public class quote implements Testlet
> {
> private TestHarness harness;
> 
> public void test (TestHarness harness)
> {
> harness.check(Pattern.quote("hello"), "\\Qhello\\E");
> harness.check(Pattern.quote("\\Q"), "\\Q\\Q\\E");
> harness.check(Pattern.quote("abc\\E123\\E"), 
> "\\Qabc\\E\\\\E\\Q123\\E\\\\E\\Q\\E");
> 
> try
> {
> Pattern.quote(null);
> harness.check(false);
> }
> catch (NullPointerException e)
> {
> harness.check(true);
> }
> }
> }




More information about the Classpath-patches mailing list