[cp-patches] FYI: Improving Locale Support

Andrew Hughes ahughes at redhat.com
Tue Jan 31 15:41:26 UTC 2012


I'm currently committing a series of patches to both cp-tools and
Classpath to improve our locale support.  The Mauve test described here:

http://sourceware.org/ml/mauve-patches/2012/msg00000.html
 
was created in response to a Fedora bug:

https://bugzilla.redhat.com/show_bug.cgi?id=712013

which identified holes in our locale data.

An initial fix was already applied:

http://developer.classpath.org/pipermail/classpath-patches/2012-January/006634.html

which fixes the initial bug, but there are still a number of issues
with cp-tools picking up the wrong data.  I've recently applied the following fixes:

1. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00003.html to make cp-tools use generics, avoiding a mass of warnings.
2. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00004.htm to refactor cp-tools, specifically making ListDataElement use modern collections and private fields.
3. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00005.html removes JavaGenerator, a dead class which is causing unnecessary
extra work.
4. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00006.html makes the output property files sorted by key so they can be compared.
5. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00007.html is the corresponding commit of sorted property files to Classpath
6. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00009.html prevents the cp-tools parser overwriting data when they use the same
type attribute.  Now all values are stored with draft and alternative text, so that the best can be selected.  We were previously picking proposed data rather than the default data.
7. https://lists.gnu.org/archive/html/commit-classpath/2012-01/msg00008.html updates Classpath's property files after this change.

All but 5 & 7 are patches to cp-tools, not Classpath.

I've attached all but patch 5.  Patch 5 is 6 megabytes in size and contains no changes.  It just replaces the property files with ones
using the exact same data but sorted keys.  This kind of diff is exactly why we made this change, and it allows 7 to be as simple and
clear as it is.

We still need a further change so that the correct block of calendar data (format type rather than standalone type) is used.  I'm working
on this now, and will hopefully post it later today.
--
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: locale-09.diff
Type: text/x-patch
Size: 734237 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20120131/651d8a3a/attachment-0006.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: generics-02.diff
Type: text/x-patch
Size: 23386 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20120131/651d8a3a/attachment-0007.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bad_choices-01.diff
Type: text/x-patch
Size: 18913 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20120131/651d8a3a/attachment-0008.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sorted.patch
Type: text/x-patch
Size: 2737 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20120131/651d8a3a/attachment-0009.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-01.diff
Type: text/x-patch
Size: 39546 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20120131/651d8a3a/attachment-0010.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-02.diff
Type: text/x-patch
Size: 29510 bytes
Desc: not available
Url : http://developer.classpath.org/pipermail/classpath-patches/attachments/20120131/651d8a3a/attachment-0011.bin 


More information about the Classpath-patches mailing list