[PATCH] Honour CPNIO_DSYNC flag if set.

Andrew Hughes gnu.andrew at redhat.com
Tue Jul 28 14:46:23 UTC 2015


----- Original Message -----
> Hello,
> 
> Don't want to bug you, but have you had the chance to look into this?
> 

Hi Guillermo,

Sorry, I've been busy with the OpenJDK security updates.
I'll try and look into both this week.

Thanks for your patience.

> Guillermo
> 
> 2015-01-29 18:16 GMT+01:00 Andrew Hughes <gnu.andrew at redhat.com>:
> >
> >
> > ----- Original Message -----
> >> Hello. Any feedback?
> >>
> >>
> >> 2015-01-20 14:10 GMT+01:00 grodriguez <guille.rodriguez at gmail.com>:
> >>
> >> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was honoured).
> >> > This was breaking at least RandomFileAccess when open in "rwd" mode
> >> > ("rws" would work as expected).
> >> >
> >> > ---
> >> >  native/jni/java-nio/gnu_java_nio_VMChannel.c |    3 ++-
> >> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >> >
> >> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > index 7899f0b..6a1cf48 100644
> >> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env,
> >> >             | ((mode & CPNIO_APPEND) ? O_APPEND :
> >> >                ((nmode == O_WRONLY) ? O_TRUNC : 0))
> >> >             | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
> >> > -           | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
> >> > +           | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
> >> > +           | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
> >> >
> >> >    npath = JCL_jstring_to_cstring (env, path);
> >> >
> >> > --
> >> > 1.7.0.4
> >> >
> >> >
> >>
> >>
> >> --
> >> Guillermo Rodriguez Garcia
> >> guille.rodriguez at gmail.com
> >>
> >
> > Thanks. I'll apply the patch as soon as I can.
> > --
> > Andrew :)
> >
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
> > Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> >
> > PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
> > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
> >
> 
> 
> 
> --
> Guillermo Rodriguez Garcia
> guille.rodriguez at gmail.com
> 
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the Classpath mailing list